johannes/assistant
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(vela): retire legacy mocked turn trigger

Browse Source
This commit is contained in:
Johannes Kresner
2026-04-08 21:50:18 +02:00
parent 28712443cc
commit 8e14eaeed0
10 changed files with 78 additions and 378 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/vela-gateway/src/index.js
View File

@@ -11,7 +11,6 @@ const {
const WEBSOCKET_ROUTE = '/ws';
const WEBSOCKET_GUID = '258EAFA5-E914-47DA-95CA-C5AB0DC85B11';
const MOCKED_USER_TRANSCRIPT = '[mocked user] What is the current mocked vertical slice?';
const MOCKED_ASSISTANT_RESPONSE = '[mocked assistant] This is a deterministic mocked response from the gateway vertical slice.';
function createPlaceholderPartialTranscript(audioChunkCount) {
@@ -67,7 +66,7 @@ function scheduleMockedTurnStep(session, turnId, delay, callback) {
session.mockedTurnTimers.push(timer);
}
function startMockedTurn(socket, session, { transcript = MOCKED_USER_TRANSCRIPT, includeListeningState = true } = {}) {
function startMockedTurn(socket, session, { transcript, includeListeningState = true } = {}) {
if (session.mockedTurnInFlight) {
sendSocketError(socket, 'mocked_turn_in_flight', 'Only one mocked turn can run per session at a time.');
return;
@@ -246,7 +245,11 @@ function handleClientMessage(socket, session, rawMessage) {
sendSocketMessage(socket, 'session.state', { value: session.state });
break;
case 'mocked.turn.trigger':
startMockedTurn(socket, session);
sendSocketError(
socket,
'unsupported_mocked_turn_trigger',
'mocked.turn.trigger is no longer supported; use input_audio.append and input_audio.commit instead.'
);
break;
case 'input_audio.append':
if (session.mockedTurnInFlight) {

121
apps/vela-gateway/test/websocket-session.test.js
View File

@@ -355,7 +355,7 @@ test('websocket handles valid and invalid client messages safely', async () => {
}
});
test('websocket accepts a placeholder input cycle before a mocked turn on the same socket', async () => {
test('websocket accepts repeated placeholder input cycles on the same socket', async () => {
const server = await startServer();
try {
@@ -403,11 +403,15 @@ test('websocket accepts a placeholder input cycle before a mocked turn on the sa
payload: { value: 'idle' }
});
client.sendJson({ type: 'mocked.turn.trigger', payload: {} });
client.sendJson({ type: 'input_audio.append', payload: { chunk: 'placeholder-control-shell-chunk-2' } });
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'listening' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'transcript.partial',
payload: { text: '[mocked partial] Placeholder push-to-talk transcript in progress.' }
});
await client.close();
} finally {
@@ -516,7 +520,7 @@ test('websocket emits deterministic partials for repeated appends and a determin
}
});
test('websocket mocked turn emits deterministic transcript and response events in order', async () => {
test('websocket rejects the retired mocked.turn.trigger path deterministically', async () => {
const server = await startServer();
try {
@@ -526,110 +530,17 @@ test('websocket mocked turn emits deterministic transcript and response events i
client.sendJson({ type: 'mocked.turn.trigger', payload: {} });
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'listening' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'transcript.final',
payload: { text: '[mocked user] What is the current mocked vertical slice?' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'thinking' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'speaking' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'response.text.delta',
payload: { text: '[mocked assistant] ' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'response.text.delta',
payload: { text: 'This is a deterministic mocked response from the gateway vertical slice.' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'response.completed',
payload: {}
});
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'idle' }
});
await client.close();
} finally {
await server.close();
}
});
test('websocket rejects a second mocked turn while one is in flight', async () => {
const server = await startServer();
try {
const client = await connectWebSocket(server.port);
await client.nextMessage();
await client.nextMessage();
client.sendJson({ type: 'mocked.turn.trigger', payload: {} });
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'listening' }
});
client.sendJson({ type: 'mocked.turn.trigger', payload: {} });
assert.deepEqual(await client.nextMessage(), {
type: 'error',
payload: {
code: 'mocked_turn_in_flight',
message: 'Only one mocked turn can run per session at a time.',
code: 'unsupported_mocked_turn_trigger',
message:
'mocked.turn.trigger is no longer supported; use input_audio.append and input_audio.commit instead.',
retryable: true
}
});
await client.close();
} finally {
await server.close();
}
});
test('websocket cancel stops an active mocked turn and allows a new one without reconnecting', async () => {
const server = await startServer();
try {
const client = await connectWebSocket(server.port);
await client.nextMessage();
await client.nextMessage();
client.sendJson({ type: 'mocked.turn.trigger', payload: {} });
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'listening' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'transcript.final',
payload: { text: '[mocked user] What is the current mocked vertical slice?' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'thinking' }
});
client.sendJson({ type: 'response.cancel', payload: {} });
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'idle' }
});
await assert.rejects(() => client.nextMessage(150), /timed out waiting for websocket message/);
client.sendJson({ type: 'mocked.turn.trigger', payload: {} });
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'listening' }
});
await client.close();
} finally {
await server.close();
@@ -671,11 +582,15 @@ test('websocket cancel stops a push-to-talk commit response and allows another t
});
await assert.rejects(() => client.nextMessage(150), /timed out waiting for websocket message/);
client.sendJson({ type: 'mocked.turn.trigger', payload: {} });
client.sendJson({ type: 'input_audio.append', payload: { chunk: 'chunk-2' } });
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'listening' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'transcript.partial',
payload: { text: '[mocked partial] Placeholder push-to-talk transcript in progress.' }
});
await client.close();
} finally {
@@ -694,11 +609,15 @@ test('websocket safely accepts cancel when no turn is active', async () => {
client.sendJson({ type: 'response.cancel', payload: {} });
await assert.rejects(() => client.nextMessage(150), /timed out waiting for websocket message/);
client.sendJson({ type: 'mocked.turn.trigger', payload: {} });
client.sendJson({ type: 'input_audio.append', payload: { chunk: 'chunk-1' } });
assert.deepEqual(await client.nextMessage(), {
type: 'session.state',
payload: { value: 'listening' }
});
assert.deepEqual(await client.nextMessage(), {
type: 'transcript.partial',
payload: { text: '[mocked partial] Placeholder push-to-talk transcript in progress.' }
});
await client.close();
} finally {