johannes/assistant
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(vela): retire legacy mocked turn trigger

Browse Source
This commit is contained in:
Johannes Kresner
2026-04-08 21:50:18 +02:00
parent 28712443cc
commit 8e14eaeed0
10 changed files with 78 additions and 378 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/vela-ui/README.md
View File

@@ -7,7 +7,7 @@ Current status:
- SvelteKit app boots in the Yarn workspace
- root page shows a minimal voice-session shell with connect/disconnect controls
- the shell can connect to the gateway `/ws` endpoint and display developer-visible session status
- the shell can trigger one deterministic mocked turn and render the mocked transcript plus assistant response
- the current mocked interaction path is push-to-talk only and renders the mocked transcript plus assistant response
- Vitest covers connect/disconnect plus the deterministic mocked transcript/response UI flow without requiring a browser harness
- Playwright remains optional for deeper browser-level checks
- microphone capture and audio playback remain future increments

95
apps/vela-ui/e2e/voice-session.spec.js
View File

@@ -1,87 +1,15 @@
import { expect, test } from '@playwright/test';
const MOCKED_USER_TRANSCRIPT = '[mocked user] What is the current mocked vertical slice?';
const MOCKED_ASSISTANT_RESPONSE =
'[mocked assistant] This is a deterministic mocked response from the gateway vertical slice.';
test('voice session shell covers the mocked transcript/response slice', async ({ page }) => {
test('voice session shell supports the placeholder push-to-talk path', async ({ page }) => {
await page.goto('/');
await expect(page.getByTestId('hydration-status')).toHaveText('ready');
await expect(page.getByTestId('connection-state')).toHaveText('not connected');
await expect(page.getByTestId('mocked-turn-button')).toBeDisabled();
await expect(page.getByTestId('session-id')).toHaveText('not assigned');
await expect(page.getByTestId('gateway-session-state')).toHaveText('not received');
await page.getByTestId('connect-button').click();
await expect(page.getByTestId('connection-state')).toHaveText('connected');
await expect(page.getByTestId('gateway-session-state')).toHaveText('idle');
await expect(page.getByTestId('session-id')).not.toHaveText('not assigned');
await expect(page.getByTestId('mocked-turn-button')).toBeEnabled();
const sessionId = await page.getByTestId('session-id').textContent();
await page.getByTestId('mocked-turn-button').click();
await expect(page.getByTestId('mocked-turn-status')).toHaveText('running');
await expect(page.getByTestId('user-transcript')).toHaveText('waiting for mocked transcript…');
await expect(page.getByTestId('assistant-response')).toHaveText('waiting for mocked response…');
await expect(page.getByTestId('user-transcript')).toHaveText(MOCKED_USER_TRANSCRIPT);
await expect(page.getByTestId('assistant-response')).toHaveText(MOCKED_ASSISTANT_RESPONSE);
await expect(page.getByTestId('conversation-render-order')).toHaveText('transcript>response');
await expect(page.getByTestId('mocked-turn-status')).toHaveText('idle');
await page.getByTestId('disconnect-button').click();
await expect(page.getByTestId('connection-state')).toHaveText('disconnected');
await expect(page.getByTestId('connection-detail')).toHaveText('Gateway WebSocket is closed.');
await expect(page.getByTestId('gateway-session-state')).toHaveText('idle');
await expect(page.getByTestId('session-id')).toHaveText(sessionId ?? '');
await expect(page.getByTestId('mocked-turn-button')).toBeDisabled();
await expect(page.getByTestId('user-transcript')).toHaveText(MOCKED_USER_TRANSCRIPT);
await expect(page.getByTestId('assistant-response')).toHaveText(MOCKED_ASSISTANT_RESPONSE);
await expect(page.getByTestId('session-id')).toHaveText(sessionId ?? '');
await expect(page.getByTestId('gateway-session-state')).toHaveText('idle');
await expect(page.getByTestId('user-transcript')).toHaveText(MOCKED_USER_TRANSCRIPT);
await expect(page.getByTestId('assistant-response')).toHaveText(MOCKED_ASSISTANT_RESPONSE);
});
test('voice session shell can cancel an active mocked turn and start another one', async ({ page }) => {
await page.goto('/');
await expect(page.getByTestId('hydration-status')).toHaveText('ready');
await expect(page.getByTestId('cancel-turn-button')).toBeDisabled();
await page.getByTestId('connect-button').click();
await expect(page.getByTestId('connection-state')).toHaveText('connected');
await expect(page.getByTestId('mocked-turn-button')).toBeEnabled();
await page.getByTestId('mocked-turn-button').click();
await expect(page.getByTestId('mocked-turn-status')).toHaveText('running');
await expect(page.getByTestId('cancel-turn-button')).toBeEnabled();
await expect(page.getByTestId('user-transcript')).toHaveText(MOCKED_USER_TRANSCRIPT);
await expect(page.getByTestId('assistant-response')).toContainText('[mocked assistant]');
await page.getByTestId('cancel-turn-button').click();
await expect(page.getByTestId('gateway-session-state')).toHaveText('idle');
await expect(page.getByTestId('mocked-turn-status')).toHaveText('idle');
await expect(page.getByTestId('cancel-turn-button')).toBeDisabled();
await expect(page.getByTestId('mocked-turn-button')).toBeEnabled();
await expect(page.getByTestId('user-transcript')).toHaveText(MOCKED_USER_TRANSCRIPT);
await expect(page.getByTestId('assistant-response')).toContainText('[mocked assistant]');
await page.getByTestId('mocked-turn-button').click();
await expect(page.getByTestId('mocked-turn-status')).toHaveText('running');
await expect(page.getByTestId('assistant-response')).toHaveText(MOCKED_ASSISTANT_RESPONSE);
await expect(page.getByTestId('mocked-turn-status')).toHaveText('idle');
});
test('voice session shell supports a placeholder mic-control cycle before another mocked turn', async ({ page }) => {
await page.goto('/');
await expect(page.getByTestId('hydration-status')).toHaveText('ready');
await expect(page.getByTestId('mic-control-button')).toBeDisabled();
await expect(page.getByTestId('mocked-turn-button')).toHaveCount(0);
await page.getByTestId('connect-button').click();
@@ -95,10 +23,6 @@ test('voice session shell supports a placeholder mic-control cycle before anothe
await expect(page.getByTestId('partial-transcript')).toHaveText(
'[mocked partial] Placeholder push-to-talk transcript in progress.'
);
await expect(page.getByTestId('user-transcript')).toHaveText(
'[mocked partial] Placeholder push-to-talk transcript in progress.'
);
await expect(page.getByTestId('mocked-turn-button')).toBeDisabled();
await page.getByTestId('mic-control-button').dispatchEvent('mouseup');
await expect(page.getByTestId('mic-control-status')).toHaveText('idle');
@@ -108,15 +32,10 @@ test('voice session shell supports a placeholder mic-control cycle before anothe
await expect(page.getByTestId('assistant-response')).toHaveText(MOCKED_ASSISTANT_RESPONSE);
await expect(page.getByTestId('partial-transcript')).toHaveText('none');
await expect(page.getByTestId('gateway-session-state')).toHaveText('idle');
await expect(page.getByTestId('mocked-turn-button')).toBeEnabled();
await page.getByTestId('mocked-turn-button').click();
await expect(page.getByTestId('mocked-turn-status')).toHaveText('running');
await expect(page.getByTestId('assistant-response')).toHaveText(MOCKED_ASSISTANT_RESPONSE);
await expect(page.getByTestId('mocked-turn-status')).toHaveText('idle');
await expect(page.getByTestId('mic-control-button')).toBeEnabled();
});
test('voice session shell can cancel a push-to-talk mocked response and start another turn', async ({ page }) => {
test('voice session shell can cancel a push-to-talk mocked response and start another push-to-talk turn', async ({ page }) => {
await page.goto('/');
await expect(page.getByTestId('hydration-status')).toHaveText('ready');
@@ -140,9 +59,11 @@ test('voice session shell can cancel a push-to-talk mocked response and start an
'[mocked final] Placeholder push-to-talk transcript completed from 1 appended chunk.'
);
await expect(page.getByTestId('assistant-response')).toContainText('[mocked assistant]');
await expect(page.getByTestId('mocked-turn-button')).toBeEnabled();
await expect(page.getByTestId('mic-control-button')).toBeEnabled();
await page.getByTestId('mocked-turn-button').click();
await page.getByTestId('mic-control-button').dispatchEvent('mousedown');
await expect(page.getByTestId('gateway-session-state')).toHaveText('listening');
await page.getByTestId('mic-control-button').dispatchEvent('mouseup');
await expect(page.getByTestId('assistant-response')).toHaveText(MOCKED_ASSISTANT_RESPONSE);
await expect(page.getByTestId('mocked-turn-status')).toHaveText('idle');
});

44
apps/vela-ui/src/lib/VoiceSessionShell.svelte
View File

@@ -58,15 +58,6 @@
let micControlActive = false;
let hydrationStatus = 'mounting';
$: canTriggerMockedTurn =
typeof WebSocket !== 'undefined' &&
connectionState === 'connected' &&
socket?.readyState === WebSocket.OPEN &&
sessionReadyReceived &&
gatewaySessionState === 'idle' &&
!micControlActive &&
!mockedTurnInFlight;
$: canCancelMockedTurn =
typeof WebSocket !== 'undefined' &&
connectionState === 'connected' &&
@@ -132,33 +123,6 @@
socket.send(JSON.stringify(createMessageEnvelope('input_audio.commit', {})));
}
function triggerMockedTurn() {
if (!socket || socket.readyState !== WebSocket.OPEN || connectionState !== 'connected') {
connectionDetail = 'Connect to the gateway before triggering a mocked turn.';
lastError = 'mocked turn requires an active WebSocket connection';
return;
}
if (!sessionReadyReceived) {
connectionDetail = 'Wait for the gateway session to be ready before triggering a mocked turn.';
lastError = 'mocked turn requires session.ready';
return;
}
if (mockedTurnInFlight) {
connectionDetail = 'A mocked turn is already running for this session.';
return;
}
mockedUserTranscript = 'waiting for mocked transcript…';
inProgressPartialTranscript = 'none';
mockedAssistantResponse = 'waiting for mocked response…';
mockedTurnInFlight = true;
assistantResponseExpected = true;
lastError = 'none';
socket.send(JSON.stringify(createMessageEnvelope('mocked.turn.trigger', {})));
}
function cancelActiveResponse() {
if (!socket || socket.readyState !== WebSocket.OPEN || connectionState !== 'connected') {
connectionDetail = 'Connect to the gateway before cancelling a mocked turn.';
@@ -363,9 +327,8 @@
<p class="eyebrow">Vela UI</p>
<h1>Voice session shell</h1>
<p>
This minimal browser shell can connect to the gateway WebSocket, trigger one deterministic
mocked turn, and expose a push-to-talk control shell that only sends placeholder protocol
events for the active session.
This minimal browser shell can connect to the gateway WebSocket and expose a push-to-talk
control shell that only sends placeholder protocol events for the active session.
</p>
<p class="contract-note">
@@ -408,9 +371,6 @@
>
Disconnect
</button>
<button data-testid="mocked-turn-button" on:click={triggerMockedTurn} disabled={!canTriggerMockedTurn}>
Run mocked turn
</button>
<button data-testid="cancel-turn-button" on:click={cancelActiveResponse} disabled={!canCancelMockedTurn}>
Cancel active turn
</button>

123
apps/vela-ui/tests/voice-session.test.js
View File

@@ -67,7 +67,7 @@ describe('voice session shell', () => {
render(VoiceSessionShell);
expect(getByTestId('connection-state').textContent).toBe('not connected');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(true);
expect(screen.queryByTestId('mocked-turn-button')).toBeNull();
expect(getByTestId('mic-control-button').hasAttribute('disabled')).toBe(true);
await fireEvent.click(getByTestId('connect-button'));
@@ -78,7 +78,7 @@ describe('voice session shell', () => {
await waitFor(() => {
expect(getByTestId('connection-state').textContent).toBe('connected');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(false);
expect(screen.queryByTestId('mocked-turn-button')).toBeNull();
expect(getByTestId('mic-control-button').hasAttribute('disabled')).toBe(false);
});
@@ -87,13 +87,13 @@ describe('voice session shell', () => {
await waitFor(() => {
expect(getByTestId('connection-state').textContent).toBe('disconnected');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(true);
expect(screen.queryByTestId('mocked-turn-button')).toBeNull();
expect(getByTestId('mic-control-button').hasAttribute('disabled')).toBe(true);
expect(getByTestId('session-id').textContent).toBe('session-123');
});
});
it('runs a placeholder mic-control cycle, streams mocked assistant text, and keeps mocked turn usable on the same socket', async () => {
it('runs a placeholder mic-control cycle, streams mocked assistant text, and leaves push-to-talk usable on the same socket', async () => {
render(VoiceSessionShell);
await fireEvent.click(getByTestId('connect-button'));
@@ -131,7 +131,6 @@ describe('voice session shell', () => {
await waitFor(() => {
expect(getByTestId('gateway-session-state').textContent).toBe('listening');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(true);
expect(getByTestId('user-transcript').textContent).toBe(
'[mocked partial] Placeholder push-to-talk transcript in progress.'
);
@@ -168,20 +167,15 @@ describe('voice session shell', () => {
await waitFor(() => {
expect(getByTestId('gateway-session-state').textContent).toBe('idle');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(false);
expect(getByTestId('mic-control-button').hasAttribute('disabled')).toBe(false);
expect(getByTestId('user-transcript').textContent).toBe(
'[mocked final] Placeholder push-to-talk transcript completed from 1 appended chunk.'
);
expect(getByTestId('assistant-response').textContent).toBe(
'[mocked assistant] This is a deterministic mocked response from the gateway vertical slice.'
);
expect(getByTestId('partial-transcript').textContent).toBe('none');
expect(getByTestId('partial-transcript').textContent).toBe('none');
});
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(socket.sent).toHaveLength(3);
expect(JSON.parse(socket.sent[2]).type).toBe('mocked.turn.trigger');
});
it('keeps rendered push-to-talk transcript and assistant text visible after cancel', async () => {
@@ -239,118 +233,33 @@ describe('voice session shell', () => {
});
});
it('renders mocked transcript before assistant response for a connected session', async () => {
it('shows protocol errors returned for the retired mocked turn trigger path', async () => {
render(VoiceSessionShell);
await fireEvent.click(getByTestId('connect-button'));
const socket = MockWebSocket.latest();
socket.open();
socket.message(createMessageEnvelope('session.ready', { sessionId: 'session-456' }));
socket.message(createMessageEnvelope('session.ready', { sessionId: 'session-legacy' }));
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('connection-state').textContent).toBe('connected');
});
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(socket.sent).toHaveLength(1);
const sentMessage = JSON.parse(socket.sent[0]);
expect(sentMessage.type).toBe('mocked.turn.trigger');
socket.message(createMessageEnvelope('session.state', { value: 'listening' }));
socket.message(
createMessageEnvelope('transcript.partial', {
text: '[mocked partial] Placeholder push-to-talk transcript in progress.'
createMessageEnvelope('error', {
code: 'unsupported_mocked_turn_trigger',
message:
'mocked.turn.trigger is no longer supported; use input_audio.append and input_audio.commit instead.',
retryable: true
})
);
socket.message(createMessageEnvelope('transcript.final', { text: 'Turn on the office lamp.' }));
socket.message(createMessageEnvelope('session.state', { value: 'thinking' }));
socket.message(createMessageEnvelope('session.state', { value: 'speaking' }));
socket.message(createMessageEnvelope('response.text.delta', { text: 'Mocked ' }));
socket.message(createMessageEnvelope('response.text.delta', { text: 'assistant response.' }));
socket.message(createMessageEnvelope('response.completed', { reason: 'mocked_turn_complete' }));
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('user-transcript').textContent).toBe('Turn on the office lamp.');
expect(getByTestId('partial-transcript').textContent).toBe('none');
expect(getByTestId('assistant-response').textContent).toBe('Mocked assistant response.');
expect(getByTestId('conversation-render-order').textContent).toBe('transcript>response');
expect(getByTestId('last-error').textContent).toBe(
'unsupported_mocked_turn_trigger: mocked.turn.trigger is no longer supported; use input_audio.append and input_audio.commit instead.'
);
expect(getByTestId('gateway-session-state').textContent).toBe('idle');
});
});
it('blocks mocked turn trigger before session.ready and allows it after session.ready', async () => {
render(VoiceSessionShell);
await fireEvent.click(getByTestId('connect-button'));
const socket = MockWebSocket.latest();
socket.open();
await waitFor(() => {
expect(getByTestId('connection-state').textContent).toBe('connected');
});
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(true);
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(socket.sent).toHaveLength(0);
expect(getByTestId('last-error').textContent).toBe('mocked turn requires session.ready');
socket.message(createMessageEnvelope('session.ready', { sessionId: 'session-789' }));
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(false);
});
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(socket.sent).toHaveLength(1);
expect(JSON.parse(socket.sent[0]).type).toBe('mocked.turn.trigger');
});
it('shows cancel control during an active mocked turn and preserves rendered text after cancel', async () => {
render(VoiceSessionShell);
await fireEvent.click(getByTestId('connect-button'));
const socket = MockWebSocket.latest();
socket.open();
socket.message(createMessageEnvelope('session.ready', { sessionId: 'session-cancel' }));
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('cancel-turn-button').hasAttribute('disabled')).toBe(true);
});
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(JSON.parse(socket.sent[0]).type).toBe('mocked.turn.trigger');
socket.message(createMessageEnvelope('session.state', { value: 'listening' }));
socket.message(createMessageEnvelope('transcript.final', { text: 'Keep this transcript.' }));
socket.message(createMessageEnvelope('session.state', { value: 'thinking' }));
socket.message(createMessageEnvelope('session.state', { value: 'speaking' }));
socket.message(createMessageEnvelope('response.text.delta', { text: 'Partial response' }));
await waitFor(() => {
expect(getByTestId('cancel-turn-button').hasAttribute('disabled')).toBe(false);
expect(getByTestId('assistant-response').textContent).toBe('Partial response');
});
await fireEvent.click(getByTestId('cancel-turn-button'));
expect(JSON.parse(socket.sent[1]).type).toBe('response.cancel');
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('mocked-turn-status').textContent).toBe('idle');
expect(getByTestId('gateway-session-state').textContent).toBe('idle');
expect(getByTestId('cancel-turn-button').hasAttribute('disabled')).toBe(true);
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(false);
expect(getByTestId('user-transcript').textContent).toBe('Keep this transcript.');
expect(getByTestId('assistant-response').textContent).toBe('Partial response');
});
});
});