johannes/assistant
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(vela): retire legacy mocked turn trigger

Browse Source
This commit is contained in:
Johannes Kresner
2026-04-08 21:50:18 +02:00
parent 28712443cc
commit 8e14eaeed0
10 changed files with 78 additions and 378 deletions
Download Patch File Download Diff File Expand all files Collapse all files

123
apps/vela-ui/tests/voice-session.test.js
View File

@@ -67,7 +67,7 @@ describe('voice session shell', () => {
render(VoiceSessionShell);
expect(getByTestId('connection-state').textContent).toBe('not connected');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(true);
expect(screen.queryByTestId('mocked-turn-button')).toBeNull();
expect(getByTestId('mic-control-button').hasAttribute('disabled')).toBe(true);
await fireEvent.click(getByTestId('connect-button'));
@@ -78,7 +78,7 @@ describe('voice session shell', () => {
await waitFor(() => {
expect(getByTestId('connection-state').textContent).toBe('connected');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(false);
expect(screen.queryByTestId('mocked-turn-button')).toBeNull();
expect(getByTestId('mic-control-button').hasAttribute('disabled')).toBe(false);
});
@@ -87,13 +87,13 @@ describe('voice session shell', () => {
await waitFor(() => {
expect(getByTestId('connection-state').textContent).toBe('disconnected');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(true);
expect(screen.queryByTestId('mocked-turn-button')).toBeNull();
expect(getByTestId('mic-control-button').hasAttribute('disabled')).toBe(true);
expect(getByTestId('session-id').textContent).toBe('session-123');
});
});
it('runs a placeholder mic-control cycle, streams mocked assistant text, and keeps mocked turn usable on the same socket', async () => {
it('runs a placeholder mic-control cycle, streams mocked assistant text, and leaves push-to-talk usable on the same socket', async () => {
render(VoiceSessionShell);
await fireEvent.click(getByTestId('connect-button'));
@@ -131,7 +131,6 @@ describe('voice session shell', () => {
await waitFor(() => {
expect(getByTestId('gateway-session-state').textContent).toBe('listening');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(true);
expect(getByTestId('user-transcript').textContent).toBe(
'[mocked partial] Placeholder push-to-talk transcript in progress.'
);
@@ -168,20 +167,15 @@ describe('voice session shell', () => {
await waitFor(() => {
expect(getByTestId('gateway-session-state').textContent).toBe('idle');
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(false);
expect(getByTestId('mic-control-button').hasAttribute('disabled')).toBe(false);
expect(getByTestId('user-transcript').textContent).toBe(
'[mocked final] Placeholder push-to-talk transcript completed from 1 appended chunk.'
);
expect(getByTestId('assistant-response').textContent).toBe(
'[mocked assistant] This is a deterministic mocked response from the gateway vertical slice.'
);
expect(getByTestId('partial-transcript').textContent).toBe('none');
expect(getByTestId('partial-transcript').textContent).toBe('none');
});
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(socket.sent).toHaveLength(3);
expect(JSON.parse(socket.sent[2]).type).toBe('mocked.turn.trigger');
});
it('keeps rendered push-to-talk transcript and assistant text visible after cancel', async () => {
@@ -239,118 +233,33 @@ describe('voice session shell', () => {
});
});
it('renders mocked transcript before assistant response for a connected session', async () => {
it('shows protocol errors returned for the retired mocked turn trigger path', async () => {
render(VoiceSessionShell);
await fireEvent.click(getByTestId('connect-button'));
const socket = MockWebSocket.latest();
socket.open();
socket.message(createMessageEnvelope('session.ready', { sessionId: 'session-456' }));
socket.message(createMessageEnvelope('session.ready', { sessionId: 'session-legacy' }));
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('connection-state').textContent).toBe('connected');
});
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(socket.sent).toHaveLength(1);
const sentMessage = JSON.parse(socket.sent[0]);
expect(sentMessage.type).toBe('mocked.turn.trigger');
socket.message(createMessageEnvelope('session.state', { value: 'listening' }));
socket.message(
createMessageEnvelope('transcript.partial', {
text: '[mocked partial] Placeholder push-to-talk transcript in progress.'
createMessageEnvelope('error', {
code: 'unsupported_mocked_turn_trigger',
message:
'mocked.turn.trigger is no longer supported; use input_audio.append and input_audio.commit instead.',
retryable: true
})
);
socket.message(createMessageEnvelope('transcript.final', { text: 'Turn on the office lamp.' }));
socket.message(createMessageEnvelope('session.state', { value: 'thinking' }));
socket.message(createMessageEnvelope('session.state', { value: 'speaking' }));
socket.message(createMessageEnvelope('response.text.delta', { text: 'Mocked ' }));
socket.message(createMessageEnvelope('response.text.delta', { text: 'assistant response.' }));
socket.message(createMessageEnvelope('response.completed', { reason: 'mocked_turn_complete' }));
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('user-transcript').textContent).toBe('Turn on the office lamp.');
expect(getByTestId('partial-transcript').textContent).toBe('none');
expect(getByTestId('assistant-response').textContent).toBe('Mocked assistant response.');
expect(getByTestId('conversation-render-order').textContent).toBe('transcript>response');
expect(getByTestId('last-error').textContent).toBe(
'unsupported_mocked_turn_trigger: mocked.turn.trigger is no longer supported; use input_audio.append and input_audio.commit instead.'
);
expect(getByTestId('gateway-session-state').textContent).toBe('idle');
});
});
it('blocks mocked turn trigger before session.ready and allows it after session.ready', async () => {
render(VoiceSessionShell);
await fireEvent.click(getByTestId('connect-button'));
const socket = MockWebSocket.latest();
socket.open();
await waitFor(() => {
expect(getByTestId('connection-state').textContent).toBe('connected');
});
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(true);
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(socket.sent).toHaveLength(0);
expect(getByTestId('last-error').textContent).toBe('mocked turn requires session.ready');
socket.message(createMessageEnvelope('session.ready', { sessionId: 'session-789' }));
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(false);
});
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(socket.sent).toHaveLength(1);
expect(JSON.parse(socket.sent[0]).type).toBe('mocked.turn.trigger');
});
it('shows cancel control during an active mocked turn and preserves rendered text after cancel', async () => {
render(VoiceSessionShell);
await fireEvent.click(getByTestId('connect-button'));
const socket = MockWebSocket.latest();
socket.open();
socket.message(createMessageEnvelope('session.ready', { sessionId: 'session-cancel' }));
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('cancel-turn-button').hasAttribute('disabled')).toBe(true);
});
await fireEvent.click(getByTestId('mocked-turn-button'));
expect(JSON.parse(socket.sent[0]).type).toBe('mocked.turn.trigger');
socket.message(createMessageEnvelope('session.state', { value: 'listening' }));
socket.message(createMessageEnvelope('transcript.final', { text: 'Keep this transcript.' }));
socket.message(createMessageEnvelope('session.state', { value: 'thinking' }));
socket.message(createMessageEnvelope('session.state', { value: 'speaking' }));
socket.message(createMessageEnvelope('response.text.delta', { text: 'Partial response' }));
await waitFor(() => {
expect(getByTestId('cancel-turn-button').hasAttribute('disabled')).toBe(false);
expect(getByTestId('assistant-response').textContent).toBe('Partial response');
});
await fireEvent.click(getByTestId('cancel-turn-button'));
expect(JSON.parse(socket.sent[1]).type).toBe('response.cancel');
socket.message(createMessageEnvelope('session.state', { value: 'idle' }));
await waitFor(() => {
expect(getByTestId('mocked-turn-status').textContent).toBe('idle');
expect(getByTestId('gateway-session-state').textContent).toBe('idle');
expect(getByTestId('cancel-turn-button').hasAttribute('disabled')).toBe(true);
expect(getByTestId('mocked-turn-button').hasAttribute('disabled')).toBe(false);
expect(getByTestId('user-transcript').textContent).toBe('Keep this transcript.');
expect(getByTestId('assistant-response').textContent).toBe('Partial response');
});
});
});